Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize massmail #95

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
52c0762
start modernization of massmail
otizonaizit Apr 5, 2023
d927cac
fix test_massmail
otizonaizit Apr 5, 2023
492aebc
fix test_local_sending
otizonaizit Apr 5, 2023
ea0e6fb
implement a hidden option '-f' to allow for testing
otizonaizit Apr 5, 2023
f936080
define additional hidden option '-t' to disable TLS (useful for testing)
otizonaizit Apr 5, 2023
cfbe480
fix test with fake smtp server
otizonaizit Apr 5, 2023
dd5344b
use the python local to the environment to run the smtp server
otizonaizit Apr 6, 2023
1a1681c
use pytest for testing and click for the CLI interface
otizonaizit Apr 6, 2023
2493c85
biiiig rewrite
otizonaizit Apr 6, 2023
ffaeab9
first version of the test for the modernized API...
otizonaizit Apr 14, 2023
02bc042
use new SMTP.send_message method, which allows us to simplify the sen…
otizonaizit Apr 15, 2023
3155974
use get_payload instead of get_content to get a decode string of the …
otizonaizit Apr 15, 2023
42afd21
added a bunch of tests
otizonaizit Apr 15, 2023
9fc15a0
remove redundant imports
otizonaizit Apr 15, 2023
b28d479
refactor tests and add test with wild unicode characters
otizonaizit Apr 15, 2023
614b990
Revert "use get_payload instead of get_content to get a decode string…
otizonaizit Apr 15, 2023
1bd0b83
use a better way of representing options while testing
otizonaizit Apr 15, 2023
99ec1f0
properly handle SMTP server binary output in tests
otizonaizit Apr 15, 2023
13ac9f8
allow for testing errors in script
otizonaizit Apr 15, 2023
dd985a5
rename smtpuser and smtppassword options
otizonaizit Apr 15, 2023
9c0af74
rename smtpuser and smtppassword options
otizonaizit Apr 15, 2023
3f0945c
remove --separator option. We just force the use of ';'
otizonaizit Apr 15, 2023
20e62e8
renamed in-reply-to option
otizonaizit Apr 15, 2023
63efa25
added tests for all options
otizonaizit Apr 15, 2023
c7568a4
added test for invalid inreply-to
otizonaizit Apr 15, 2023
c9ec4e2
added an email address validator
otizonaizit Apr 16, 2023
170aeaf
refactor error management in the tests
otizonaizit Apr 16, 2023
3c1b88c
add tests for email validator
otizonaizit Apr 16, 2023
ac1726f
factored out the email validator so that it can be used everywhere in…
otizonaizit Apr 16, 2023
ad37ad6
help debugging failing test by printing the script output on unexpect…
otizonaizit Apr 16, 2023
0a8ed2a
validate email addresses from parameter file
otizonaizit Apr 16, 2023
2c3cdb8
added more email address validation tests
otizonaizit Apr 16, 2023
5432140
hide options from --help output that we only should use in tests
otizonaizit Apr 16, 2023
a03ff54
new feature: it is now possible to add mutiple attachments
otizonaizit Apr 16, 2023
f79831b
add tests for the attachment feature
otizonaizit Apr 16, 2023
415eabb
added a test for an unkown attachment type
otizonaizit Apr 16, 2023
30a05ca
removed unused --force option
otizonaizit Apr 16, 2023
d2aea3a
remove --no-tls option. We can now test using TLS
otizonaizit Apr 16, 2023
340d532
do not allow for empty values in parameter file
otizonaizit Apr 16, 2023
117333b
also print SMTP protocol log when unexpectedly failing a test
otizonaizit Apr 16, 2023
b066e33
add detailed explanation about the magic happening in re.sub
otizonaizit Apr 16, 2023
628a92c
complain if an unknown key is found in the body text
otizonaizit Apr 16, 2023
4b7e354
warn if no keys are found in the body text
otizonaizit Apr 16, 2023
baba19f
use rich for color and progress report
otizonaizit Apr 16, 2023
3830a94
allow for standalone running withoout installation
otizonaizit Apr 16, 2023
5df4a5e
the malformed line count error did not take into account the header o…
otizonaizit Feb 22, 2024
4239241
allow for empty values
otizonaizit Aug 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove redundant imports
otizonaizit committed Apr 15, 2023
commit 9fc15a0cb66576140996c24f22cedd6baf84ab58
6 changes: 1 addition & 5 deletions massmail/test_massmail.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
import contextlib
import email as email_module
import io
import subprocess
import sys
import os
import time
import subprocess
import base64

from massmail.massmail import main as massmail
import click.testing