-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/#323] 430기준으로 반응형 뷰 적용 #324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeunseo
changed the title
[ Feat/#323 ] 430기준으로 반응형 뷰 적용
[Feat/#323] 430기준으로 반응형 뷰 적용
Aug 23, 2024
simeunseo
reviewed
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌀 해당 이슈 번호
🔹 어떤 것을 변경했나요?
BottomBtnWrapper
컴포넌트 안에 children으로 버튼 컴포넌트를 넣으면 전체 너비에 맞게 버튼을 가운데로 정렬해주고, 버튼이 두개이상일 땐 gap을 적용합니다.🔹 어떻게 구현했나요?
window.innerWidth || document.documentElement.clientWidth
로 뷰포트의 크기를 확인하여 뷰포트와 430px중 더 작은 너비로 전체 appWrapper의 크기를 지정해주면서 responsive한 모바일 뷰를 구현하였습니다.데스크탑 환경에서는 430px이 더 작은 값이니 430px로 보입니다.
🔹 PR 포인트를 알려주세요!
BottomBtnWrapper 가 중복되고 atom 컴포넌트인 Button 컴포넌트를 활용할 수 있는 명확한 moleculesComponent라고 생각하는데 이부분에 대해 은서님의 생각도 궁금합니다
🔹 스크린샷을 남겨주세요!
default.mp4