instruments/trace_cmd: Add tracing mode support to TraceCmdInstrument() #1276
Conversation
Implement tracing mode support (mainly for write-to-disk mode) in TraceCmdInstrument, enabling efficient collection of large trace datasets without encountering memory limitations. This feature is particularly useful for scenarios requiring extensive trace data. Additional changes: - Replace hardcoded strings with corresponding string literals for improved maintainability. Signed-off-by: Metin Kaya <[email protected]>
|
LGTM however it needs to wait until this devlib PR is merged: EDIT: strikethrough |
There was a problem hiding this comment.
Also looks good to me.
And thanks @douglas-raillard-arm for the poke on the corresponding devlib PR. I think we can avoid having to wait for a PyPi release but you're correct we'll need at least a dev bump to align these PR's when merging.
Just came back to remove that part from my comment. As long as WA's PyPI release is not pushed before devlib's one it's probably ok to only support devlib's master in WA's master branch |
Implement tracing mode support (mainly for write-to-disk mode) in TraceCmdInstrument, enabling efficient collection of large trace datasets without encountering memory limitations.
This feature is particularly useful for scenarios requiring extensive trace data.
Additional changes: