Bugfixes: big soot partilces were lost, gaussian fit in the plot was too wide, split position algorithm now more stable. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johbackm
commented
Apr 3, 2024
•
johbackm
commented
- When Ch1 is saturated, the peak width becomes nan because the PkEnd_ch1 is not found (for very big particles). Now PkEnd_ch5 is used instead, which means that we don't loose the upper end of the rBC size distribution.
- split detector algorithm more stable. Inversion of channel 3 is now hard coded which makes the algorithm find the split more consistently even if there are three lobes in the split signal.
- fixed Gaussian width issue when plotting the fit in pysp2.vis.plot_wave() Gaussian width (sigma) is FWHM/2.35482
…t point marker symbols so that they are visible when they are on top of each other.
…hannel is inverted and which one is not. In the future, we could add this to the conifguration file but I believe that this is standard and always the same.
…Otherwise we loose the largest particles and the rBC size distribution is wrong. Large particles will be missing since PkEnd_ch1 will become nan --> width = nan --> accepted_incand will become False.
|
Forgot to update values in tests.test_psds() now that the rBC mass concentrations have changed due to the missing large rBC particles. |
|
Thank you for finding these issues @johbackm ! Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.