Geoplot2

[kenkehoe]

I was having an issue with the test running and test for plot_from_u_and_v(). I also made a few minor changes to the new plotting stuff I did. This is not fixing my py.test issue but I do need the plot_from_u_and_v() to let the test pass.

[AdamTheisen]

Requesting Bobby as a reviewer.

I never had issues with the plot_from_u_and_v test so I am a little concerned about potential conflicts on the ADC system.

[rcjackson]

This looks fine to me. I'll do one test on my end here first.

[rcjackson]

I wonder if there is some sort of setting in the ADC environment that is making it fail. I'll try the test on my own end and see what I get.

[rcjackson]

For your py.test issue I tried simply running the test manually and I get this figure.

If I run it through pytest I get the greyscale version. Therefore, I think there might be an issue with pytest-mpl when it preserves the figure colormap. I'll look into raising an issue on their webpage.

[rcjackson]

I have raised this as an issue. We can see if it's truly a problem on their end or something we need to do.

matplotlib/pytest-mpl#84

[kenkehoe]

OK thanks. Can we comment out the test with our stuff for now?

[rcjackson]

Yeah let's not do the test for now. Bobby

…

________________________________ From: Ken Kehoe <[email protected]> Sent: Wednesday, May 15, 2019 10:11:03 AM To: ANL-DIGR/ACT Cc: Jackson, Robert; State change Subject: Re: [ANL-DIGR/ACT] Geoplot2 (#58) OK thanks. Can we comment out the test with our stuff for now? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub<#58>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFIQA5FJLHGWLYPISIBZ7XLPVQRYPANCNFSM4HMUHT6Q>.