Allow real GPS position to be used, even after fake GPS has been set #560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Allows real GPS position to be used even after fake GPS has been set (#500)
Can it be referenced to an Issue? If so what is the issue # ?
500
How can we test it?
Set up a fake GPS location in the HTML. Then use the application in a real GPS location. The real GPS location will be recognised.
Summary
Does this PR introduce a breaking change?
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Tested by @Platform-Group, who contributed this fix (but did not prepare the PR). Verified as sensible code by @nickw1.
@kalwalt do you need to check this, or shall I just merge into dev? It's a very simple fix.
Other information
I think it would be more sensible longer-term to allow the fake GPS to be set multiple times, which this logic prevents (as did the code before this fix). However this might possibly break existing apps so needs more testing. This can be considered a 'quick fix'