Fix Android gradle build script #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandfox
pushed a commit
to ConnectedHomes/react-native-version-number
that referenced
this pull request
Oct 2, 2018
Manually bring in PR 32 from original repo APSL#32
tessus
added a commit
to tessus/react-native-version-info
that referenced
this pull request
Oct 29, 2018
Moreno97
reviewed
Oct 30, 2018
|
|
||
| apply plugin: 'com.android.library' | ||
|
|
||
| android { | ||
| compileSdkVersion 23 | ||
| buildToolsVersion "23.0.1" | ||
| compileSdkVersion safeExtGet('compileSdkVersion', 26) |
There was a problem hiding this comment.
Can you change the version to 27?
Moreno97
reviewed
Oct 30, 2018
| compileSdkVersion 23 | ||
| buildToolsVersion "23.0.1" | ||
| compileSdkVersion safeExtGet('compileSdkVersion', 26) | ||
| buildToolsVersion safeExtGet('buildToolsVersion', '26.0.3') |
There was a problem hiding this comment.
Can you change the version to 27?
Moreno97
reviewed
Oct 30, 2018
| minSdkVersion 16 | ||
| targetSdkVersion 22 | ||
| minSdkVersion safeExtGet('minSdkVersion', 16) | ||
| targetSdkVersion safeExtGet('targetSdkVersion', 26) |
There was a problem hiding this comment.
Can you change the version to 27?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #27 but use a cleaner way to achieve the same result.
As of 0.56, we RN proj start declaring a few constants that libraries can query about.
Some library uses this technique so I'm porting it over here: