Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on shouldCallGetNode in tests #511

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix crash on shouldCallGetNode in tests #511

wants to merge 2 commits into from
+5 −1

Commits on Sep 28, 2021

  1. Update KeyboardAwareHOC.js 

    In our test suite `Platform.constants` is an empty object. This was making the previous `!Platform.constants` check pass, but caused a crash when trying to access `major` on `reactNativeVersion`.

This fix correctly checks if `reactNativeVersion` is present and is an object to avoid this issue.
    @GertjanReynaert
    GertjanReynaert authored Sep 28, 2021
    Configuration menu
    Copy the full SHA
    7b729b7 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @GertjanReynaert
    GertjanReynaert authored Sep 28, 2021
    Configuration menu
    Copy the full SHA
    532e5be View commit details
    Browse the repository at this point in the history