Add accessibility traits #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make our button more accessible on iOS according to the Doc: https://facebook.github.io/react-native/docs/accessibility.html#accessibilitytraits-ios
In order to make our button more accessible for Android according to the doc: https://facebook.github.io/react-native/docs/accessibility.html#accessibilitycomponenttype-android
In order to make the CI green again.
We had to upgrade the packages:
- jest
- react
- react-test-renderer
Add accessibility traits
Libraries that modifies native props using the reference (e.g. [styled-components](https://github.com/styled-components/styled-components)) need to know what component represent the button. Those kind of modifications are made using the method `setNativeProps`, therefore, this commit implements the references to wrappers which represent the button styles and implement the setNativeProps method at the Button component.
|
How can we get this merged into master branch ? I need this feature since I'm writing automated script for the app and accessiblityLabel is not visible using Appium Inspector. |
Moreno97
reviewed
Oct 19, 2018
| @@ -1,6 +1,6 @@ | |||
| 'use strict'; | |||
| "use strict"; | |||
There was a problem hiding this comment.
Can you change all the files with singlequote as specified on eslint rules?
|
Hi @luisfmsouza !! Thanks for your PR, can you update the Readme docs with the new props and rebase commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add accessibility props to make our button more accessible on both OSs.
Why
VoiceOver and TalkBack need this props to inform the users what kind of component is this one. With this prop we can use button, link, etc.