Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timer functionality to solve Issue #120 #166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anmolgupta2015
Copy link

@anmolgupta2015 anmolgupta2015 commented Jan 24, 2025

Summary

This pull request refactors the Output.jsx component by moving it into a new folder named output to promote modularity. Additionally, a new file Timer.jsx has been created and placed in the same folder. This approach avoids making the Output.jsx file overly large and helps maintain cleaner and more organized code.

Changes Made

  1. Moved Output.jsx to a new output folder:

    • Promotes better organization by grouping related files together.
    • Makes it easier to manage and locate components.
  2. Created Timer.jsx:

    • Built the Timer feature from scratch to provide accurate timing functionality.
    • Extracted timer-related functionality into a separate file to avoid cluttering Output.jsx.
    • Ensures a clear separation of concerns, adhering to best practices for modular development.
  3. Updated Import Statements:

    • Adjusted all relevant imports to reflect the new folder structure.

Reason for Change

  • Combining all logic in a single file (Output.jsx) would have made the codebase harder to maintain and understand.
  • Separating the timer logic into Timer.jsx ensures modularity and cleaner code for easier maintenance and extensibility.

Testing

  • Verified that all functionality remains intact after the refactor.
  • Tested the Timer component for:
    • Starting and stopping functionality.
    • Handling edge cases like rapid start/stop sequences.
    • Resetting correctly under all conditions.
  • Confirmed that the Output component integrates properly with the Timer.

Screenshots/GIFs

24.01.2025_12.38.06_REC.mp4

Issue Reference

Resolves issue #120 by adding a modular Timer feature and refactoring the Output component.

@anmolgupta2015
Copy link
Author

Hii, @Roaster05 @Aditya062003 :)
Kindly merge this code if you don't find any issues
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant