Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unsupported Python and OS versions #578

Conversation

conscribtor
Copy link
Contributor

The purpose of these changes is to fix CI tests not passing due to the Ansible 10 release being incompatible with supported OSs that have Python 3.6.
I've also made some updates in the documentation and have removed unused configuration and templates.

  • removal of EOL OS configurations in vars, tests and documentation
  • removal of Python 2 handling as all supported OSs ship with Python 3
  • pinning Ansible to v9 in Actions as v10 does not support Python 3.6 (rockylinux8)
  • add Ubuntu 22.04 to Molecule test matrix
  • mark Rockylinux 8.x as ⚠️ in the compatibility matrix since it is not compatible with Ansible v10+
  • simplify compatibility matrix states

With these changes the CI passes again.

Due to Python 3 being the default in all supported OSs, we may remove the logic that dealt with
detecting the OSs Python version and consequently installed a different set of packages.

- removed dependency on Python 2 packages (python-psycopg2)
- rephrased named steps in CI as it is explicitely set in `python-version`
- require Ansible 2.12 as it supports the auto-detection of the OS Python interpreter
- removed explicit setting of Python version in variables, playbooks and inventory
- removed unsupported configurations from test inventory
Ansible 10 uses ansible-core 2.17+ which drops Python 3.6 support and thus makes it incompatible
with Rocky Linux 8 or other RHEL 8 derivatives.
@conscribtor
Copy link
Contributor Author

@MrMegaNova @gclough

Would love to get your feedback on the changes I've made. Happy to change/revert commits if needed.

Copy link
Collaborator

@MrMegaNova MrMegaNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !
Everything seem good to be merged

@MrMegaNova MrMegaNova merged commit 176b474 into ANXS:development Jul 19, 2024
8 checks passed
@conscribtor
Copy link
Contributor Author

Thank you - Happy to contribute :-)

@conscribtor conscribtor deleted the drop-unsupported-dependencies-and-options branch July 20, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants