Add LAPPDLoadStore tool for EventBuildingV2 tool chain #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LAPPDHit and LAPPDPulse.h are for LAPPD so they are included in this PR
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LAPPDLoadStore Tool in EventBuildingV2 tool set.
This is also splited from PR #307
Changes based on your comments:
· LAPPDLoadStore around line 674/705 looks similar code to that on the monitoring toolchain which crashes and has to be worked around. There are some try/catches here too - does this throw? Perhaps these were added at my request to investigate - did you compare what this is doing with the online monitoring code and see if there are differences that may explain why the monitoring code doesn't like it?
Now it's at line 675.
I remember an error about these code last year when I started to rewrite LAPPD tools. Sometime, for some reason I don't understand (maybe related to the firmware or something before the saving in DAQ), the meta data may miss something so the length is not enough for the code to load until INFOWORD == 13 or TRIGGERWORD == 6. This happens very rare, even less than 1 event per run. But it should crash any tool chain related to LAPPD data. Now I add try/catch for that and say if there is such an error just skip that event in processing, but for old tools this might be useful. I will have a look for the monitoring tool chain maybe later next week.
· I see a new without delete - in fact is there any reason PedestalValues needs to be on the heap at all? As far as i can tell it could just be a member vector not a pointer.
There is not a specific reason, I just keep the convention from old LAPPD tools. Since everything is working fine I would perfer not to change......