New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IS-11] Fix occasional exceptions caused by undefined variables. #838

Merged

N-Nagorny merged 1 commit into AMWA-TV:is-11 from gwgeorgea:is-11-Senders-outputs-exceptions-fix

Apr 27, 2024

gwgeorgea commented Nov 1, 2023

Fix occasional exceptions caused by undefined variables.
Fix wrong list of receivers with outputs. Needed to test both audio and video properly.
New 256 byte EDID with CEA extension, prevents audio stream from going down during IS-11 test.


          - Fix occasional exceptions caused by undefined variables.

d0bbe2b

- Fix wrong list of receivers with outputs. Needed to test both audio and video properly.
- New 256 byte EDID with CEA extension, prevents audio stream from going down during IS-11 test.

gwgeorgea changed the title ~~- Fix occasional exceptions caused by undefined variables.~~ [IS-11] Fix occasional exceptions caused by undefined variables.

Collaborator

N-Nagorny commented Nov 2, 2023

It would be good to merge #836 and then revisit this one cause #836 fills in an equivalent of receivers_with_or_without_outputs in set_up_tests.

N-Nagorny reviewed

View reviewed changes

nmostesting/suites/IS1101Test.py

Comment on lines -3677 to +3678

		if (activated_receivers < len(self.receivers_with_outputs)):
		if (activated_receivers < len(self.is11_utils.receivers_with_or_without_outputs)):

Collaborator

N-Nagorny Nov 3, 2023

Please replace is11_utils.receivers_with_or_without_outputs with self.receivers.

nmostesting/suites/IS1101Test.py

Comment on lines -3679 to +3681

-                                                  .format(len(self.receivers_with_outputs) - activated_receivers))
+                                                  .format(len(self.is11_utils.receivers_with_or_without_outputs)
+                                                          - activated_receivers))

Collaborator

N-Nagorny Nov 3, 2023

Please replace is11_utils.receivers_with_or_without_outputs with self.receivers.

nmostesting/suites/IS1101Test.py

Comment on lines -3812 to +3814

		if (activated_receivers < len(self.receivers_with_outputs)):
		if (activated_receivers < len(self.is11_utils.receivers_with_or_without_outputs)):

Collaborator

N-Nagorny Nov 3, 2023

Please replace is11_utils.receivers_with_or_without_outputs with self.receivers.

nmostesting/suites/IS1101Test.py

Comment on lines -3814 to +3817

-                                                  .format(len(self.receivers_with_outputs) - activated_receivers))
+                                                  .format(len(self.is11_utils.receivers_with_or_without_outputs)
+                                                          - activated_receivers))

Collaborator

N-Nagorny Nov 3, 2023

Please replace is11_utils.receivers_with_or_without_outputs with self.receivers.

nmostesting/suites/IS1101Test.py

Comment on lines -3979 to +3982

		if (activated_receivers < len(self.receivers_without_outputs)):
		if (activated_receivers < len(self.is11_utils.receivers_with_or_without_outputs)):

Collaborator

N-Nagorny Nov 3, 2023

Please replace is11_utils.receivers_with_or_without_outputs with self.receivers.

nmostesting/suites/IS1101Test.py

Comment on lines -3981 to +3985

-                                                  .format(len(self.receivers_without_outputs) - activated_receivers))
+                                                  .format(len(self.is11_utils.receivers_with_or_without_outputs)
+                                                          - activated_receivers))

Collaborator

N-Nagorny Nov 3, 2023

Please replace is11_utils.receivers_with_or_without_outputs with self.receivers.

nmostesting/suites/IS1101Test.py

Comment on lines -4023 to +4027

		if (activated_receivers < len(self.receivers_without_outputs)):
		if (activated_receivers < len(self.is11_utils.receivers_with_or_without_outputs)):

Collaborator

N-Nagorny Nov 3, 2023

Please replace is11_utils.receivers_with_or_without_outputs with self.receivers.

nmostesting/suites/IS1101Test.py

Comment on lines -4025 to +4030

-                                                  .format(len(self.receivers_without_outputs) - activated_receivers))
+                                                  .format(len(self.is11_utils.receivers_with_or_without_outputs)
+                                                          - activated_receivers))

Collaborator

N-Nagorny Nov 3, 2023

Please replace is11_utils.receivers_with_or_without_outputs with self.receivers.

N-Nagorny merged commit adae812 into AMWA-TV:is-11

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet