Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass IP address of API under test to testssl.sh #832

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

garethsb
Copy link
Contributor

@garethsb garethsb commented Oct 5, 2023

So that same one is used by Python tests and testssl.sh tests

So that same one is used by Python tests and testssl.sh tests

Co-authored-by: Simon Lo <[email protected]>
Copy link
Contributor

@peterbrightwell peterbrightwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, or at least matches the option parsing in testssl.sh

Copy link

@pedro-alves-ferreira pedro-alves-ferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garethsb garethsb merged commit ad0e39d into master Oct 5, 2023
1 check passed
@garethsb garethsb deleted the testssl-sh-ip branch October 5, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants