python-zeroconf 0.75.0 strict=False for _nmos-registration._tcp #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethsb
force-pushed
the
zeroconf-strict-false
branch
from
58fa577
to
0a591c9
Compare
Libraries like python-zeroconf are starting to depend on more recent Python features
garethsb
force-pushed
the
zeroconf-strict-false
branch
from
0a591c9
to
b10ff71
Compare
|
Quick test with new build, looks like it's working... docker pull amwa/nmos-testing:zeroconf-strict-false-b10ff71 |
|
I have pulled the docker image and verified that it is working; I have run the IS-05-01 tests, in particular test_41 which uses SDPoker, and this ran successfully. So LGTM |
|
Jonathan also now tested IS-04-01 with v1.2 (strictly invalid
Unfortunately there was a build error when I tried to bump node 14.x all the way to node 18.x, so I reverted that change back to node 16.x. I'll make another PR for that after we merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #828.
Could have just put
strict=Falseon all theregister_servicecalls that advertise the Registration API, but figured might as well passFalseonly when we believe that's necessary: for_nmos-registration._tcpand not for_nmos-register._tcp.