Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abort on unused parmparse variables in input file in tests #725

Merged
merged 13 commits into from
Dec 19, 2023

Conversation

baperry2
Copy link
Contributor

So excess/deprecated inputs don't build up and cause confusion.

@baperry2
Copy link
Contributor Author

@marchdf @jrood-nrel how do we feel about this? I haven't gone through all the input files yet, but the ones changed here are representative. It catches some deprecated and/or irrelevant inputs, but mostly just catches amr.ref_ratio and amr.regrid_int` for cases without AMR.

@jrood-nrel
Copy link
Contributor

Love it.

@marchdf
Copy link
Contributor

marchdf commented Dec 14, 2023

I like it. I wish we could ignore the ref_ratio and regrid_int when max_level = 0. It's less stuff to change when we change the max level... but maybe that's too much to ask?

@baperry2
Copy link
Contributor Author

We could put dummy queries for these just so they always get touched, but I'm not a big fan of that. IMO not a big deal just to uncomment those lines when adding levels.

@marchdf
Copy link
Contributor

marchdf commented Dec 14, 2023

yeah probably fine.

@baperry2 baperry2 marked this pull request as ready for review December 18, 2023 19:03
@baperry2
Copy link
Contributor Author

@marchdf based on what this uncovered, it looks like the forcing for HIT case wasn't actually active, which I think I fixed. Also, the "moving plane" EB geometry and corresponding EB-Plane test seem to not really do anything, so I deleted them. Can you double check these changes?

@baperry2 baperry2 requested a review from marchdf December 18, 2023 19:14
@marchdf
Copy link
Contributor

marchdf commented Dec 18, 2023

nice work!

@baperry2 baperry2 enabled auto-merge (squash) December 18, 2023 21:42
@baperry2 baperry2 merged commit e7bf202 into AMReX-Combustion:development Dec 19, 2023
13 checks passed
@baperry2 baperry2 deleted the pp-abort branch February 24, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants