Fix report_single_test for cases with NaNs #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function was broken by AMReX-Codes/amrex#3823. When a variable contains NaNs, the line used to be "< NaN present >\n", but now it's "< NaN present >" followed by white spaces and then '\n'. In that case, the line is split into three fields and we should skip the last field with just white spaces.
zingale
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was broken by AMReX-Codes/amrex#3823. When a variable contains NaNs, the line used to be
< NaN present >\n, but now it's< NaN present >followed by white spaces and then\n. In that case, the line is now split into three fields instead of two, and we should skip the last field with just white spaces.