Fail loudly if new benchmark has no output. #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--make_benchmarks
is on, a misconfigured / buggy test program might fail to produce any output. If this happens, the regression testing script will continue executing and eventually crash when it can't find the.status
file that it is expecting to be there, creating an unintuitive backtrace that does not make clear the root cause of the problem:This PR fixes the above by failing with a clear error message as soon as it can be determined that output from the test program cannot be found.