Helpers: to_numpy/cupy #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
topic-helpers-np-cupy
branch
5 times, most recently
from
1d3fad4
to
3b0c2ab
Compare
ax3l
force-pushed
the
topic-helpers-np-cupy
branch
6 times, most recently
from
5cd8a6d
to
6758c74
Compare
1 task
ax3l
force-pushed
the
topic-helpers-np-cupy
branch
6 times, most recently
from
d8da7df
to
e83ea3c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| SoA_cp = namedtuple(type(self).__name__ + "_cp", ["real", "int"]) | ||
|
|
||
| soa_view = SoA_cp([], []) |
Check notice
Code scanning / CodeQL
Unused local variable Note
ax3l
force-pushed
the
topic-helpers-np-cupy
branch
2 times, most recently
from
5d1c35b
to
4b4d780
Compare
ax3l
force-pushed
the
topic-helpers-np-cupy
branch
from
4b4d780
to
8d25a23
Compare
ax3l
force-pushed
the
topic-helpers-np-cupy
branch
from
8d25a23
to
a7d3ebd
Compare
ax3l
force-pushed
the
topic-helpers-np-cupy
branch
from
a7d3ebd
to
816a5c4
Compare
ax3l
commented
Sep 21, 2023
Comment on lines
+37
to
+38
| if order == "F": | ||
| return np.array(self, copy=copy).T |
There was a problem hiding this comment.
Follow-up: support AMReX-side device-to-host copies.
There was a problem hiding this comment.
Added directly to MultiFab in #192
This was referenced Sep 22, 2023
Merged
ax3l
commented
Nov 5, 2023
Comment on lines
+37
to
+41
| for idx_real in range(self.NumRealComps()): | ||
| soa_view.real.append(self.GetRealData(idx_real).to_numpy(copy=copy)) | ||
|
|
||
| for idx_int in range(self.NumIntComps()): | ||
| soa_view.int.append(self.GetIntData(idx_int).to_numpy(copy=copy)) |
There was a problem hiding this comment.
Double check if runtime attributes are part of this:
#220 (comment)
ax3l
commented
Nov 5, 2023
Comment on lines
+77
to
+81
| for idx_real in range(self.NumRealComps()): | ||
| soa_view.real.append(self.GetRealData(idx_real).to_cupy(copy=copy)) | ||
|
|
||
| for idx_int in range(self.NumIntComps()): | ||
| soa_view.int.append(self.GetIntData(idx_int).to_cupy(copy=copy)) |
There was a problem hiding this comment.
See above: Double check if runtime attributes are part of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #55