Particle Container: Runtime Arguments #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
commented
Nov 6, 2023
ax3l
force-pushed
the
topic-test-runtime-args
branch
from
84a3a78 to
ea955b1
Compare
ax3l
commented
Nov 6, 2023
Comment on lines
+64
to
+66
| .def("assign", [](PODVector_type & pv, T const & value){ | ||
| pv.assign(pv.size(), value); | ||
| }, py::arg("value"), "assign the same value to every element") |
There was a problem hiding this comment.
Overloaded because vector.assign(vector.size(), 42) to set a value is a bit cumbersome.
https://github.com/AMReX-Codes/amrex/blob/47347f785f5c26f1f9e65bef8e10f2d383406ef7/Src/Base/AMReX_PODVector.H#L480-L513
There was a problem hiding this comment.
Could also call this set_value in symmetry with MultiFab, please let me know what you prefer @WeiqunZhang @atmyers
There was a problem hiding this comment.
Waiting for AMReX-Codes/amrex#3866
5 tasks
src/Particle/ParticleContainer.H
Outdated
| @@ -192,6 +192,24 @@ void make_ParticleContainer_and_Iterators (py::module &m, std::string allocstr) | |||
| .def_property_readonly_static("NArrayReal", [](const py::object&){return ParticleContainerType::NArrayReal; }) | |||
| .def_property_readonly_static("NArrayInt", [](const py::object&){return ParticleContainerType::NArrayInt; }) | |||
|
|
|||
| .def_property_readonly("num_runtime_real_comps", &ParticleContainerType::NumRuntimeRealComps) | |||
| .def_property_readonly("num_runtime_int_comps", &ParticleContainerType::NumRuntimeIntComps) | |||
| .def_property_readonly("num_real_comps", &ParticleContainerType::NumRealComps) | |||
There was a problem hiding this comment.
So once this is merged we can clean up the WarpXparticleContainer.cpp file, for example the line at https://github.com/ECP-WarpX/WarpX/blob/b3ba07df16de4e9736b01a8cc7024740714dcad6/Source/Python/Particles/WarpXParticleContainer.cpp#L88, right?
|
Looks like something does not deallocate PC runtime components in time. |
ax3l
force-pushed
the
development
branch
7 times, most recently
from
6c95aa1 to
b35493b
Compare
ax3l
force-pushed
the
topic-test-runtime-args
branch
2 times, most recently
from
dc334e7 to
630a156
Compare
ax3l
force-pushed
the
topic-test-runtime-args
branch
2 times, most recently
from
35c19c9 to
e44ff54
Compare
ax3l
force-pushed
the
topic-test-runtime-args
branch
from
e44ff54 to
069fd62
Compare
ax3l
commented
Dec 5, 2023
ax3l
force-pushed
the
topic-test-runtime-args
branch
from
069fd62 to
ef4557e
Compare
ax3l
force-pushed
the
topic-test-runtime-args
branch
2 times, most recently
from
faf529e to
b534827
Compare
ax3l
force-pushed
the
topic-test-runtime-args
branch
from
b534827 to
f0b4a64
Compare
ax3l
commented
Feb 16, 2024
atmyers
pushed a commit
to AMReX-Codes/amrex
that referenced
this pull request
Mar 29, 2024
## Summary When adding new `Real`/`Int` runtime components, they could be made available without additional calls. The cost should be the same as calling it explicitly later, but clarifies the usage. Alternatively, we should add API contract details to the `AddRealComp`/`AddIntComp` doc strings to make sure people use it right. ## Additional background - AMReX-Codes/pyamrex#220 - AMReX-Codes/pyamrex#222 ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [x] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
2 tasks
ax3l
force-pushed
the
topic-test-runtime-args
branch
3 times, most recently
from
7f3d297 to
1e44d7b
Compare
ax3l
force-pushed
the
topic-test-runtime-args
branch
from
1e44d7b to
67cd6cf
Compare
5 tasks
WeiqunZhang
pushed a commit
to AMReX-Codes/amrex
that referenced
this pull request
Apr 2, 2024
## Summary ``` vector.assign(vector.size(), 42); ``` is a bit verbose for a standard operation, even if it mirrors https://en.cppreference.com/w/cpp/container/vector/assign Add another overload similar to `setVal(ue)` used in other AMReX containers. ## Additional background AMReX-Codes/pyamrex#222 (comment) ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [x] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #220
X-ref: AMReX-Codes/amrex#3615