Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and fix versioning #173

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Aug 11, 2023

This is a more robust design and does not depend on extra hackery in setup.py.

Needed in AMReX-Codes/amrex-tutorials#95

@ax3l ax3l added the bug Something isn't working label Aug 11, 2023
@ax3l ax3l force-pushed the fix-amrex-version branch 3 times, most recently from 3720086 to 0575317 Compare August 11, 2023 21:34
@ax3l ax3l requested a review from atmyers August 12, 2023 00:52
@ax3l ax3l requested a review from WeiqunZhang August 12, 2023 00:52
@ax3l ax3l merged commit 3429948 into AMReX-Codes:development Aug 12, 2023
16 checks passed
@ax3l ax3l deleted the fix-amrex-version branch August 12, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants