-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parm parse getter query for selected types (int, bool, Real) #158
Merged
ax3l
merged 7 commits into
AMReX-Codes:development
from
RevathiJambunathan:ParmParse_getter_query
Jul 22, 2023
Merged
Parm parse getter query for selected types (int, bool, Real) #158
ax3l
merged 7 commits into
AMReX-Codes:development
from
RevathiJambunathan:ParmParse_getter_query
Jul 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RevathiJambunathan
force-pushed
the
ParmParse_getter_query
branch
2 times, most recently
from
July 21, 2023 20:58
3c78f76
to
78d5e31
Compare
…ests Co-authored-by: Edoardo Zoni <[email protected]> Co-authored-by: Axel Huebl <[email protected]>
RevathiJambunathan
force-pushed
the
ParmParse_getter_query
branch
from
July 21, 2023 21:01
5eb03fe
to
39f7f33
Compare
ax3l
reviewed
Jul 21, 2023
ax3l
reviewed
Jul 21, 2023
ax3l
reviewed
Jul 21, 2023
Co-authored-by: Axel Huebl <[email protected]>
ax3l
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you :)
for more information, see https://pre-commit.ci
ax3l
reviewed
Jul 21, 2023
ax3l
reviewed
Jul 21, 2023
ax3l
reviewed
Jul 21, 2023
ax3l
reviewed
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add bindings for ParmParse get and query functions in amrex.
We also include to test, to demonstrate the use of the python bindings
Thanks to @EZoni and @ax3l for the team work!