Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parm parse getter query for selected types (int, bool, Real) #158

Merged

Conversation

RevathiJambunathan
Copy link
Contributor

In this PR, we add bindings for ParmParse get and query functions in amrex.

We also include to test, to demonstrate the use of the python bindings

Thanks to @EZoni and @ax3l for the team work!

@ax3l ax3l self-requested a review July 21, 2023 20:48
@ax3l ax3l self-assigned this Jul 21, 2023
@ax3l ax3l added the enhancement New feature or request label Jul 21, 2023
@RevathiJambunathan RevathiJambunathan force-pushed the ParmParse_getter_query branch 2 times, most recently from 3c78f76 to 78d5e31 Compare July 21, 2023 20:58
tests/test_parmparse.py Outdated Show resolved Hide resolved
tests/test_parmparse.py Outdated Show resolved Hide resolved
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you :)

tests/test_parmparse.py Fixed Show fixed Hide fixed
tests/test_parmparse.py Fixed Show fixed Hide fixed
tests/test_parmparse.py Outdated Show resolved Hide resolved
tests/test_parmparse.py Outdated Show resolved Hide resolved
tests/test_parmparse.py Outdated Show resolved Hide resolved
tests/test_parmparse.py Fixed Show fixed Hide fixed
tests/test_parmparse.py Fixed Show fixed Hide fixed
tests/test_parmparse.py Outdated Show resolved Hide resolved
@ax3l ax3l merged commit 494ad40 into AMReX-Codes:development Jul 22, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants