Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include pyAMReX.H & ODR Fix #149

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Include pyAMReX.H & ODR Fix #149

merged 1 commit into from
Jul 19, 2023

Commits on Jul 19, 2023

  1. Include pyAMReX.H & ODR Fix 

    We provide a single helper include now for all pyAMReX compilation
units (TUs) / cpp files.

This ensures that optional pybind11 includes, e.g., for stl, numpy,
functions and operators, are consistently present in all TUs. This is
required to avoid C++ one-definition-rule (ODR) violations, which are
undefined behavior and thus could cause instabilities down the road.
    @ax3l
    ax3l committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    b881a08 View commit details
    Browse the repository at this point in the history