Fix: PC Tile Copy w/ Names #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot a `define()` that also needs to forward the names of SoA components. This fixes it.
atmyers
approved these changes
Jan 17, 2025
ax3l
added a commit
to ax3l/pyamrex
that referenced
this pull request
Jan 17, 2025
Update to latest commit in `development`. Pull in fix AMReX-Codes/amrex#4298 for AMReX-Codes#382.
4 tasks
ax3l
added a commit
to AMReX-Codes/pyamrex
that referenced
this pull request
Jan 23, 2025
Update to latest commit in `development`. Pull in fixes - [x] AMReX-Codes/amrex#4298 - [x] AMReX-Codes/amrex#4299 - [x] AMReX-Codes/amrex#4302 - [x] AMReX-Codes/amrex#4300 for #382.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We forgot a
define()that also needs to forward the names of SoA components. This fixes it.Additional background
First seen in AMReX-Codes/pyamrex#382
Checklist
The proposed changes: