Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BL_PROFILE instead of BL_PROFILE_VAR to time in knapsack()swap #4134

Merged

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Sep 5, 2024

This timer was using BL_PROFILE_VAR without an associated BL_PROFILE_STOP, resulting in unused variable warnings. It seems to me that we can just use BL_PROFILE here and rely on scope to stop the timer.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers enabled auto-merge (squash) September 5, 2024 20:13
@atmyers atmyers merged commit b454719 into AMReX-Codes:development Sep 5, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants