EB Boundary Area: Fix issues for anisotropic cell size #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In 2D, the scaling in incorrect. For example, if dx >> dy and the boundary is parallel to the x-direction, it would produce inf for the scaled boundary area. * In 3D, the scaling has been modified so that it's easy to convert from the dimensionless boundary area to physical units.
asalmgren
approved these changes
Sep 5, 2024
|
I will update the documentation and then merge. |
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Sep 6, 2024
Missing sqrt.
WeiqunZhang
added a commit
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2D, the scaling in incorrect. For example, if dx >> dy and the boundary is parallel to the x-direction, it would produce inf for the scaled boundary area.
In 3D, the scaling has been modified so that it's easy to convert from the dimensionless boundary area to physical units.