Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix start_comp offset in tracer particle routines #4098

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix start_comp offset in tracer particle routines #4098

merged 1 commit into from
Aug 20, 2024

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Aug 20, 2024 •
edited
Loading

This makes the routines work as expected given the variable names (currently, ncomp was being treated as end_comp)

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers enabled auto-merge (squash) August 20, 2024 02:25
@WeiqunZhang WeiqunZhang mentioned this pull request Aug 20, 2024
Open
@atmyers atmyers merged commit baec46e into AMReX-Codes:development Aug 20, 2024
71 of 72 checks passed
RevathiJambunathan
RevathiJambunathan reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@RevathiJambunathan RevathiJambunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @atmyers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RevathiJambunathan RevathiJambunathan RevathiJambunathan left review comments

@asalmgren asalmgren asalmgren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atmyers @asalmgren @RevathiJambunathan