Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use atomic load in SYCL version of the single-pass scan #3419

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Use atomic load in SYCL version of the single-pass scan #3419

merged 1 commit into from
Jul 12, 2023

Conversation

WeiqunZhang
Copy link
Member

Otherwise the single-pass scan of long ints will hang because it does not load the most recent data even though the member function is volatile.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang
Use atomic load in SYCL version of the single-pass scan
f1394c5 
Otherwise the single-pass scan of long ints will hang because it does not
load the most recent data even though the member function is volatile.
@WeiqunZhang WeiqunZhang requested a review from atmyers July 12, 2023 20:07
@WeiqunZhang WeiqunZhang merged commit 5117d21 into AMReX-Codes:development Jul 12, 2023
66 checks passed
@WeiqunZhang WeiqunZhang deleted the sycl_scan branch July 12, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmyers atmyers atmyers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeiqunZhang @atmyers