Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU: Add Device::deviceVendor() function and fix #3416 #3418

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

mirenradia
Copy link
Contributor

Summary

This adds a function that returns the GPU's vendor.

Additional background

This function is only really relevant for SYCL (although only Intel GPUs are officially supported with the SYCL backend AFAIK). For CUDA and HIP it is inferred at compile time.

This function is used to disable SIGSEGV handling by default on Intel GPUs to fix #3416. In theory, we could only default disable SIGSEGV handling for specific Intel GPU architectures (e.g. using the experimental oneAPI SYCL Device Architecture extension) since integrated Intel GPUs are not affected by #3416 but this would need to be updated every time Intel releases a new GPU architecture which still uses SIGSEGV for managed memory. It is simpler to disable it by default on all Intel GPUs.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

Note that this is only really relevant for SYCL. For CUDA and HIP is is
inferred at compile time.
SIGSEGV handling currently interferes with the managed memory
implementation on Intel's discrete GPUs. In theory, we could only
disable sigsegv handling for specific Intel GPU architectures (e.g.
using the experimental oneAPI SYCL Device Architecture extension
(https://github.com/intel/llvm/blob/48be219e238ca2354a1e9e9989752aa7a60b5627/sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc)
but this would need to be updated every time Intel releases a new GPU
architecture which still uses SIGSEGV for managed memory. It is simpler
to disable it by default on all Intel GPUs.

This fixes AMReX-Codes#3416.
@WeiqunZhang WeiqunZhang merged commit 59a3106 into AMReX-Codes:development Jul 12, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sigsegv handler interferes with Intel GPU managed memory migration
2 participants