generalize interpolaters to not need or use extra values in a directi… #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for which the refinement ratio is 1
|
We may need to update all the interpolation kernels including |
…to fix_interp_for_ratio1
WeiqunZhang
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on for which the refinement ratio is 1
Summary
The previous version of the interpolation routines in AmrCore would grow the "CoarseBox" in all directions even if one of the directions had refinement ratio 1. This PR changes that behavior so the CoarseBox is not grown, and slopes are not computed, in any direction for which the refinement ratio is 1.
Additional background
Checklist
The proposed changes: