Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function for setting growth factor #3394

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Add function for setting growth factor #3394

merged 1 commit into from
Jul 1, 2023

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Jun 30, 2023 •
edited
Loading

Summary

Additional background

Add the ability to set the custom vector growth factor through a function, instead of only as a runtime input.

Also reducing the min allowed factor, as there seems to be demand for that.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers requested a review from WeiqunZhang June 30, 2023 22:02
@WeiqunZhang WeiqunZhang merged commit 97724eb into AMReX-Codes:development Jul 1, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @WeiqunZhang