Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom growth factor #3393

Closed
wants to merge 7 commits into from
Closed

Custom growth factor #3393

wants to merge 7 commits into from

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Jun 30, 2023 •
edited
Loading

Add the ability to set the custom vector growth factor through a function, instead of only as a runtime input.

Also reducing the min allowed factor, as there seems to be demand for that.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers requested a review from WeiqunZhang June 30, 2023 21:50
@atmyers atmyers closed this Jun 30, 2023
@atmyers atmyers deleted the custom_growth_factor branch June 30, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang Awaiting requested review from WeiqunZhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atmyers