Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allocateSlice for EB #3391

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Fix allocateSlice for EB #3391

merged 1 commit into from
Jul 15, 2023

Conversation

WeiqunZhang
Copy link
Member

The slice data has a different BoxArray, so we cannot use the original Factory.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang
Fix allocateSlice for EB
a7a2dd8 
The slice data has a different BoxArray, so we cannot use the original
Factory.
@WeiqunZhang
Copy link
Member Author

@dpgrote

@WeiqunZhang WeiqunZhang requested a review from atmyers June 29, 2023 21:22
@WeiqunZhang
Copy link
Member Author

@dpgrote reported that this fixed the issue he had.

@asalmgren asalmgren merged commit 5376bf8 into AMReX-Codes:development Jul 15, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalmgren asalmgren asalmgren approved these changes

@atmyers atmyers Awaiting requested review from atmyers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeiqunZhang @asalmgren