ParticleTile: More SoA Updates #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| template <typename T = ParticleType, typename std::enable_if<T::is_soa_particle, int>::type = 0> | ||
| bool empty () const { return m_soa_tile.empty(); } | ||
| bool empty () const { return size() == 0; } |
There was a problem hiding this comment.
The development version for empty also works, it was fixed after I made the original PR
There was a problem hiding this comment.
True, but removing the SFINAE will improve compile time :)
atmyers
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
More updates to
ParticleTileand simplifications for pure SoA support.Additional background
Isolated from #3290 and author credited to @AlexanderSinn.
Follow-up to #2878.
Checklist
The proposed changes: