Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of bins for neighbor list construction #3195

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

Fix order of bins for neighbor list construction #3195

wants to merge 5 commits into from

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Mar 10, 2023

Do not merge until I've confirmed the MFiX-Exa tests pass.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers
Copy link
Member Author

atmyers commented Mar 10, 2023

The CPU and GPU MFiX-Exa tests pass with this change. However, there is no appreciable performance difference. Still, we should probably make this change to the bin ordering convention so it looks less "surprising" to people.

@atmyers atmyers requested a review from WeiqunZhang March 10, 2023 23:45
@atmyers atmyers marked this pull request as draft March 13, 2023 22:31
@atmyers atmyers marked this pull request as ready for review July 22, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @WeiqunZhang