Fix some warnings (#3398)

AMReX-Codes · Jul 3, 2023 · 2589f26 · 2589f26
1 parent e80199a
commit 2589f26
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/Src/Base/AMReX_NFiles.cpp b/Src/Base/AMReX_NFiles.cpp
@@ -87,9 +87,13 @@ void NFilesIter::SetDynamic(int deciderproc)
   if(currentDeciderIndex >= availableDeciders.size() || currentDeciderIndex < 0) {
     currentDeciderIndex = 0;
   }
+#if 0
+  // The following has no effect because WhichSetPostion is a pure function and
+  // its return type is not used. So not sure why this is here in the first place.
   if(myProc == deciderProc) {
     NFilesIter::WhichSetPosition(myProc, nProcs, nOutFiles, groupSets);
   }
+#endif
 
   deciderTag = ParallelDescriptor::SeqNum();
   coordinatorTag = ParallelDescriptor::SeqNum();

diff --git a/Src/Base/AMReX_VisMF.cpp b/Src/Base/AMReX_VisMF.cpp
@@ -772,7 +772,7 @@ VisMF::Header::CalculateMinMax (const FabArray<FArrayBox>& mf,
 
     BL_ASSERT(ioffset == nmtags[ParallelDescriptor::MyProc(comm)]);
 
-    Vector<Real> recvdata(mf.size()*2*m_ncomp);
+    Vector<Real> recvdata(std::size_t(mf.size())*2*m_ncomp);
 
     BL_COMM_PROFILE(BLProfiler::Gatherv, recvdata.size() * sizeof(Real),
                     ParallelDescriptor::MyProc(comm), BLProfiler::BeforeCall());

diff --git a/Src/EB/AMReX_EB_FluxRedistribute.cpp b/Src/EB/AMReX_EB_FluxRedistribute.cpp
@@ -27,29 +27,20 @@ amrex_flux_redistribute (
     int level_mask_not_covered,
     int icomp, int ncomp, Real dt)
 {
-    // if (as_crse == 0 && as_fine == 0) {
-    //     amrex::Print() << "In amrex_flux_redistribution on neither side" << std::endl;
-    // } else if (as_crse == 0 && as_fine == 1) {
-    //     amrex::Print() << "In amrex_flux_redistribution on  fine   side" << std::endl;
-    // } else if (as_crse == 1 && as_fine == 0) {
-    //     amrex::Print() << "In amrex_flux_redistribution on  coarse side" << std::endl;
-    // } else if (as_crse == 1 && as_fine == 1) {
-    //     amrex::Print() << "In amrex_flux_redistribution on  both   sides" << std::endl;
-    // }
     //
     // Check that grid is uniform
     //
     const Real* dx = geom.CellSize();
 
 #if (AMREX_SPACEDIM == 2)
     if (! amrex::almostEqual(dx[0], dx[1]))
-        amrex::Abort("apply_eb_redistribution(): grid spacing must be uniform");
 #elif (AMREX_SPACEDIM == 3)
     if( ! amrex::almostEqual(dx[0],dx[1]) ||
-        ! amrex::almostEqual(dx[0],dx[2]) ||
         ! amrex::almostEqual(dx[1],dx[2]) )
-        amrex::Abort("apply_eb_redistribution(): grid spacing must be uniform");
 #endif
+    {
+        amrex::Abort("apply_eb_redistribution(): grid spacing must be uniform");
+    }
 
     const Box dbox = geom.growPeriodicDomain(2);
     const Box& grown1_bx = amrex::grow(bx,1);