fix more warnings for CI #140
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: hip | |
| on: [push, pull_request] | |
| concurrency: | |
| group: ${{ github.ref }}-${{ github.head_ref }}-hip | |
| cancel-in-progress: true | |
| jobs: | |
| build-hip: | |
| name: HIP ROCm C++17 | |
| runs-on: ubuntu-20.04 | |
| # Have to have -Wno-deprecated-declarations due to deprecated atomicAddNoRet | |
| # Have to have -Wno-gnu-zero-variadic-macro-arguments to avoid | |
| # amrex/Src/Base/AMReX_GpuLaunchGlobal.H:15:5: error: must specify at least one argument for '...' parameter of variadic macro [-Werror,-Wgnu-zero-variadic-macro-arguments] | |
| # __launch_bounds__(amrex_launch_bounds_max_threads) | |
| # ^ | |
| # /opt/rocm-4.1.1/hip/include/hip/hcc_detail/hip_runtime.h:178:71: note: expanded from macro '__launch_bounds__' | |
| # select_impl_(__VA_ARGS__, launch_bounds_impl1, launch_bounds_impl0)(__VA_ARGS__) | |
| # ^ | |
| # /opt/rocm-4.1.1/hip/include/hip/hcc_detail/hip_runtime.h:176:9: note: macro 'select_impl_' defined here | |
| # #define select_impl_(_1, _2, impl_, ...) impl_ | |
| # Have to have -Wno-unused-command-line-argument to avoid | |
| # clang-15: error: argument unused during compilation: '-Xoffload-linker --whole-archive' [-Werror,-Wunused-command-line-argument] | |
| env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-deprecated-declarations -Wno-gnu-zero-variadic-macro-arguments -Wno-unused-command-line-argument"} | |
| steps: | |
| - uses: actions/checkout@v3 | |
| - name: Dependencies | |
| run: .github/workflows/dependencies/dependencies_hip.sh | |
| - name: Build & Install | |
| run: | | |
| source /etc/profile.d/rocm.sh | |
| hipcc --version | |
| which clang | |
| which clang++ | |
| # "mpic++ --showme" forgets open-pal in Ubuntu 20.04 + OpenMPI 4.0.3 | |
| # https://bugs.launchpad.net/ubuntu/+source/openmpi/+bug/1941786 | |
| # https://github.com/open-mpi/ompi/issues/9317 | |
| export LDFLAGS="-lopen-pal" | |
| cmake -S . -B build \ | |
| -DCMAKE_VERBOSE_MAKEFILE=ON \ | |
| -DAMReX_GPU_BACKEND=HIP \ | |
| -DAMReX_AMD_ARCH=gfx908 \ | |
| -DAMReX_ROCTX=ON \ | |
| -DCMAKE_C_COMPILER=$(which clang) \ | |
| -DCMAKE_CXX_COMPILER=$(which clang++) \ | |
| -DCMAKE_CXX_STANDARD=17 | |
| cmake --build build -j 2 | |
| tests-hip-wrapper: | |
| name: HIP ROCm [email protected] C++17 | |
| runs-on: ubuntu-20.04 | |
| # Have to have -Wno-deprecated-declarations due to deprecated atomicAddNoRet | |
| # Have to have -Wno-gnu-zero-variadic-macro-arguments to avoid | |
| # amrex/Src/Base/AMReX_GpuLaunchGlobal.H:15:5: error: must specify at least one argument for '...' parameter of variadic macro [-Werror,-Wgnu-zero-variadic-macro-arguments] | |
| # __launch_bounds__(amrex_launch_bounds_max_threads) | |
| # ^ | |
| # /opt/rocm-4.1.1/hip/include/hip/hcc_detail/hip_runtime.h:178:71: note: expanded from macro '__launch_bounds__' | |
| # select_impl_(__VA_ARGS__, launch_bounds_impl1, launch_bounds_impl0)(__VA_ARGS__) | |
| # ^ | |
| # /opt/rocm-4.1.1/hip/include/hip/hcc_detail/hip_runtime.h:176:9: note: macro 'select_impl_' defined here | |
| # #define select_impl_(_1, _2, impl_, ...) impl_ | |
| env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-deprecated-declarations -Wno-gnu-zero-variadic-macro-arguments"} | |
| steps: | |
| - uses: actions/checkout@v3 | |
| - name: Dependencies | |
| run: .github/workflows/dependencies/dependencies_hip.sh | |
| - name: Build & Install | |
| run: | | |
| source /etc/profile.d/rocm.sh | |
| hipcc --version | |
| # "mpic++ --showme" forgets open-pal in Ubuntu 20.04 + OpenMPI 4.0.3 | |
| # https://bugs.launchpad.net/ubuntu/+source/openmpi/+bug/1941786 | |
| # https://github.com/open-mpi/ompi/issues/9317 | |
| export LDFLAGS="-lopen-pal" | |
| cmake -S . -B build_full_legacywrapper \ | |
| -DCMAKE_VERBOSE_MAKEFILE=ON \ | |
| -DAMReX_GPU_RDC=OFF \ | |
| -DAMReX_GPU_BACKEND=HIP \ | |
| -DAMReX_AMD_ARCH=gfx908 \ | |
| -DAMReX_ROCTX=ON \ | |
| -DCMAKE_C_COMPILER=$(which clang) \ | |
| -DCMAKE_CXX_COMPILER=$(which hipcc) \ | |
| -DCMAKE_CXX_STANDARD=17 | |
| cmake --build build_full_legacywrapper -j 2 |