-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow single-step backward Euler integrator #1773
Allow single-step backward Euler integrator #1773
Conversation
can you also add a note to the docs here: |
Done. |
you also need to fix the style CI failures -- it looks like you used tabs and have trailing whitespace. |
also, rather than making I think that would be cleaner. |
@zingale I've added a |
you can test it with GNU make -- we don't use cmake. Just do:
in the test directory. |
Thanks, that works. I kept the changes minimal and it works just fine. |
there are also still CI style failures. |
Fixed. |
This allows the user to use a single-step Backward Euler integrator, ignoring its accuracy. There are situations where we control relative error by setting the hydro/radiation timestep, and in a reaction network we simply want a backward Euler solve and don't care about error.
To force the BackwardEuler integrator to do a single-step integration, set
integrator.do_single_step = 1
.Verified with the
burn_cell
unit test:Context: this is part of the effort to couple multi-group radiation hydrodynamics with thermochemistry in Quokka.
Addresses #1771