Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Debye Huckel Screening #1688

Merged
merged 15 commits into from
Jan 19, 2025
Merged

Implement Debye Huckel Screening #1688

merged 15 commits into from
Jan 19, 2025

Conversation

SamG-01
Copy link
Contributor

@SamG-01 SamG-01 commented Dec 13, 2024

Implements weak screening as per equation A1 of Chugunov 2009 (see below). Also adds an optional check against debye_huckel and computes the full screening factor if the check exceeds a supplied threshold, which can significantly improve runtimes (disabled by default).

image

@yut23 yut23 changed the base branch from main to development January 18, 2025 16:24
@zingale zingale merged commit 66a8b4a into AMReX-Astro:development Jan 19, 2025
32 checks passed
@SamG-01
Copy link
Contributor Author

SamG-01 commented Jan 20, 2025

[...] computes the full screening factor if the check exceeds a supplied threshold, which can significantly improve runtimes (disabled by default).

To quantify these runtime improvements, below is a benchmark of the subchandra simulation in Castro, with and without screening.enable_debye_huckel_skip, for several values of castro.react_rho_min. The stop time is 0.01 s, and screening.debye_huckel_skip_threshold is kept at its default of 1.01. Each set of runs was performed using four CPU cores of a Linux machine with 2 Intel(R) Xeon(R) Gold 5115 CPU @ 2.40GHz and a NVIDIA Titan V GPU.

output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants