Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strang nse #1549

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Conversation

zingale
Copy link
Member

@zingale zingale commented May 10, 2024

Strang does not really allow us to do 2nd order easily because we can't capture the evolution of the state during the burn

Strang does not really allow us to do 2nd order easily because we
can't capture the evolution of the state during the burn
@zingale
Copy link
Member Author

zingale commented May 10, 2024

addresses #1542

@zingale zingale added the nse label May 16, 2024
@zingale zingale changed the title [WIP] Remove strang nse Remove strang nse Jul 11, 2024
@zingale
Copy link
Member Author

zingale commented Jul 11, 2024

I think that this is good now

@zingale zingale merged commit d791e67 into AMReX-Astro:development Jul 11, 2024
29 checks passed
@zingale zingale deleted the remove_strang_nse branch July 11, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants