Fix issues with is_jacobian_term_used() #1500
Closed
+33
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three problems here. First, the logic within the function was incorrect: a Jacobian term is used if both spec1 and spec2 are connected to the same rate, rather than if either species is used. Second, this function is indexing the species using 1-indexing, but we were calling it with zero-indexed species inside the linear algebra. Third, we can only skip entries if we're using the analytical Jacobian. The numerical Jacobian will have some additional non-zero entries since it captures some physics, such as the screening, which we are not currently able to conclude in the analytical netowrk implementation.