Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a distance function #2990

Merged
merged 4 commits into from
Nov 13, 2024
Merged

add a distance function #2990

merged 4 commits into from
Nov 13, 2024

Conversation

zhichen3
Copy link
Collaborator

@zhichen3 zhichen3 commented Nov 8, 2024 •
edited
Loading

PR summary

Adds a separate function to calculate distance, mainly because the old way gets the 2d spherical case wrong.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zhichen3 zhichen3 marked this pull request as ready for review November 12, 2024 18:16
@zingale
Copy link
Member

zingale commented Nov 13, 2024

test suite: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2024-11-12-002/index.html

there is one failure with an FPE

@zhichen3
Copy link
Collaborator Author

I think its fixed now.

@zingale zingale merged commit 161c875 into AMReX-Astro:development Nov 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhichen3 @zingale