Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make const_grav in the r direction for 2D r-theta #2957

Merged
merged 2 commits into from
Sep 10, 2024
Merged

make const_grav in the r direction for 2D r-theta #2957

merged 2 commits into from
Sep 10, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Sep 10, 2024

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented Sep 10, 2024

addresses part of #2927

@zingale zingale merged commit 7059f8b into AMReX-Astro:development Sep 10, 2024
25 checks passed
@zingale zingale deleted the const_grav_r_theta branch September 11, 2024 00:28
@zingale zingale mentioned this pull request Sep 12, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhichen3 zhichen3 zhichen3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @zhichen3