Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against use_post_step_regrid when not subcycling #2639

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Protect against use_post_step_regrid when not subcycling #2639

merged 1 commit into from
Oct 17, 2023

Conversation

maxpkatz
Copy link
Member

PR summary

The castro.use_post_step_regrid parameter doesn't make sense when we're not subcycling. By the time we finish the coarse step we will already have finished all of the fine timesteps (thanks to the recent change in #2505), so there's nothing left to do.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review October 17, 2023 15:10
@zingale zingale merged commit 951276e into AMReX-Astro:development Oct 17, 2023
18 checks passed
@maxpkatz maxpkatz deleted the no_subcycling_post_step_regrid branch October 17, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxpkatz @zingale