Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement inflow BCs for the flame #2635

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

zingale
Copy link
Member

@zingale zingale commented Oct 14, 2023

PR summary

This will allow us to inflow fuel in through the right boundary to hold the flame roughly stationary. Better
still, it will hopefully remove the influence of an outflow BC on the flame propagation.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented Oct 15, 2023

I don't think this is correct yet. We need to fill the ghost cells such that when we interpolate to the boundary we get the inflow velocity on the interface. So this means I need to use the proper stencil there. I can either do this in problem_initialize_state_data.H or by modifying the stencils in the interpolation.

@zingale zingale marked this pull request as draft October 17, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant