Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish developing wrapper functions for CTU advance #2504

Merged
merged 3 commits into from
Jun 18, 2023
Merged

Finish developing wrapper functions for CTU advance #2504

merged 3 commits into from
Jun 18, 2023

Conversation

maxpkatz
Copy link
Member

PR summary

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review June 17, 2023 20:51
@zingale
Copy link
Member

zingale commented Jun 18, 2023

tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-06-17-003/index.html
some true SDC failures

@maxpkatz
Copy link
Member Author

That was a mistake left over from #2499, I added the fix to this PR.

@zingale zingale merged commit be9aba8 into AMReX-Astro:development Jun 18, 2023
14 checks passed
@maxpkatz maxpkatz deleted the more_ctu_wrappers branch June 18, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxpkatz @zingale