Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the state_nghost parameter #2502

Merged
merged 2 commits into from
Jun 17, 2023
Merged

Remove the state_nghost parameter #2502

merged 2 commits into from
Jun 17, 2023

Conversation

maxpkatz
Copy link
Member

PR summary

This was added years ago for performance testing, but was never used for any science.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review June 17, 2023 16:32
@zingale zingale merged commit 44ad0a4 into AMReX-Astro:development Jun 17, 2023
14 checks passed
@maxpkatz maxpkatz deleted the rm_state_nghost branch June 17, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxpkatz @zingale