Alternative counter collection with rocprofiler #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordap
force-pushed
the
jorda/rocprofiler-ctypes
branch
from
624ae5f to
341302a
Compare
Requires moving initialization to gunicorn's post fork stage.
jordap
force-pushed
the
jorda/rocprofiler-ctypes
branch
from
341302a to
e65e250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #12. While I think the python module for rocprofiler device mode in #12 is something that can be potentially useful beyond this project, dealing with its building and installation is more complex and not as convenient as everything else we have in Omnistat.
The implementation in this PR is based on ctypes and is 1) simpler, 2) similar to our other collectors, 3) good enough in terms of performance.
I'll be using this approach for prototyping, and we can discuss future plans later.