Company registrations form & backend list view #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vizorous
requested changes
Jun 27, 2022
| return true; | ||
| } | ||
|
|
||
| randomNumberInRange() { |
There was a problem hiding this comment.
We will have to change the logic here. Since we don't have a ton of entities, randomizer can be biased in short term and in small quantities. Entities might not be very keen on this. We should have a counter and use it.
There was a problem hiding this comment.
No changes made to this till finalized as we discussed
| } finally { | ||
| loadingDialog.close(); | ||
| } | ||
| return; |
There was a problem hiding this comment.
It is to close the loading icon and show the success message
…harrr · Pull Request AIESEC-LK#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AIESEC-LK/dev.team#39