Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add editorconfig #665

Closed
wants to merge 1 commit into from
Closed

add editorconfig #665

wants to merge 1 commit into from

Conversation

m-fila
Copy link
Contributor

@m-fila m-fila commented Sep 6, 2024

BEGINRELEASENOTES

  • Added .editorconfig for basic cross-editor configuration for generic files

ENDRELEASENOTES

Editorconfig is a popular tool for portable configuration of editors. It's automatically recognized by some editors (vim, neovim, github editor) or has a plugin for the others (emacs, vscode, clion, sublime). The tool takes lower precedence than any language specific config so there shouldn't be conflicts

Here I propose a very basic config that will automatically add newline at the end of any file so hopefully there will be less small corrections like in #660 (comment)

@jmcarcell
Copy link
Member

I'm not this will help a lot. In my opinion configuration should be done on the user side, then formatting should be automatic and done in CI; ideally we never need to run clang-format and other tools.

Here I propose a very basic config that will automatically add newline at the end of any file so hopefully there will be less small corrections like in #660 (comment)

So precisely because it's a plugin for the most used editor it's very likely it wouldn't have done anything since it's not installed by default? Some flags are supported in some plugins some are not on different plugins...

@hegner
Copy link
Collaborator

hegner commented Sep 6, 2024

I would not like adding it for similar reasons.

@m-fila
Copy link
Contributor Author

m-fila commented Sep 6, 2024

Yes, but it's meant as some minimal sane config that might be applied if not then anyway

There is a little chance that the plugin will be there (since once installed it'll be there an you can forget about it) or the editor might suggest it. The most used editor will not pop-up a suggestion for this but the extension should appear in recommended based on the files present

@m-fila
Copy link
Contributor Author

m-fila commented Sep 6, 2024

ok, closing

@m-fila m-fila closed this Sep 6, 2024
@jmcarcell
Copy link
Member

I'm not opposed to adding it, I just don't think it's going to be very useful for people that make those mistakes

@tmadlener
Copy link
Collaborator

I think it could be useful given the VSCode support and that that is what many people nowadays use. For those it would take care of a few otherwise annoying things. The rest probably has their editor configured in some other way in any case, so for them it doesn't do any harm either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants